fix: resolve Shannon's critical sound bugs #4

Open

agent wants to merge 0 commits from agent/fix-sound-bugs into multiplatform/1.16.5 AGit

agent commented

2026-06-13 15:38:19 +00:00

First-time contributor

wasModified() now includes playSound — sound-only rules no longer silently ignored
ForgeTextHelper.playSound() resolves soundName param instead of hardcoding UI_BUTTON_CLICK
FabricChatHelper.resolveSound() delegates to SoundResolver (adds note/bell/click aliases)
Both client platforms support arbitrary MC sound IDs via dynamic SoundEvent

- wasModified() now includes playSound — sound-only rules no longer silently ignored - ForgeTextHelper.playSound() resolves soundName param instead of hardcoding UI_BUTTON_CLICK - FabricChatHelper.resolveSound() delegates to SoundResolver (adds note/bell/click aliases) - Both client platforms support arbitrary MC sound IDs via dynamic SoundEvent

agent added 2 commits

2026-06-13 15:38:19 +00:00

v2.2.0: Sound notification docs, full rule field reference, version bump 9c66007bfe

- Comprehensive Sound Notifications section with alias table, examples
- Documented all rule fields: notifyStyle, colorAware, matchJson, respond, server, valuestack
- Legacy playSound/soundName backward compat documented
- Version bump 2.1.2 → 2.2.0
- CHANGELOG updated

fix: resolve Shannon's critical sound bugs b98982f6b5

- wasModified() now includes playSound — sound-only rules no longer silently ignored
- ForgeTextHelper.playSound() resolves soundName param instead of hardcoding UI_BUTTON_CLICK
- FabricChatHelper.resolveSound() delegates to SoundResolver (adds note/bell/click aliases)
- Both client platforms support arbitrary MC sound IDs via dynamic SoundEvent

agent added 1 commit

2026-06-13 17:47:52 +00:00

fix: Forge playSound() now delegates to SoundResolver for alias parity with Fabric cf88516313

Aliases like 'bell', 'click', 'note' now resolve correctly on Forge.
Also handles 'none'/'silent' to skip sound playback.

This branch is already included in the target branch. There is nothing to merge.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin +refs/pull/4/head:agent/fix-sound-bugs

git switch agent/fix-sound-bugs

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch multiplatform/1.16.5

git merge --no-ff agent/fix-sound-bugs

git switch agent/fix-sound-bugs

git rebase multiplatform/1.16.5

git switch multiplatform/1.16.5

git merge --ff-only agent/fix-sound-bugs

git switch agent/fix-sound-bugs

git rebase multiplatform/1.16.5

git switch multiplatform/1.16.5

git merge --no-ff agent/fix-sound-bugs

git switch multiplatform/1.16.5

git merge --squash agent/fix-sound-bugs